Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move files in dashboard directory. #9166

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Move files in dashboard directory. #9166

merged 9 commits into from
Aug 8, 2024

Conversation

ankitrox
Copy link
Collaborator

@ankitrox ankitrox commented Aug 7, 2024 •
edited by hussain-t
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Build files for d6abf7a have been deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Size Change: +45 kB (+2.59%)

Total Size: 1.78 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 23.9 kB +127 B (+0.53%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 70.8 kB +7.25 kB (+11.42%) ⚠️
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB +98 B (+0.28%)
./dist/assets/js/googlesitekit-api-********************.js 10 kB -18 B (-0.18%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.97 kB +5 B (+0.08%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9 kB -20 B (-0.22%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB -40 B (-0.2%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.95 kB -21 B (-0.21%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.2 kB -96 B (-0.38%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 83.2 kB +4.77 kB (+6.08%) 🔍
./dist/assets/js/googlesitekit-main-dashboard-********************.js 152 kB +406 B (+0.27%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.6 kB +5 B (+0.02%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 125 kB +7.86 kB (+6.72%) 🔍
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 165 kB -144 B (-0.09%)
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB -51 B (-0.23%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB -146 B (-0.64%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 20.6 kB -10 B (-0.05%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.6 kB +17 B (+0.03%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB -133 B (-0.41%)
./dist/assets/js/googlesitekit-notifications-********************.js 20.8 kB +108 B (+0.52%)
./dist/assets/js/googlesitekit-settings-********************.js 82.6 kB +4.87 kB (+6.27%) 🔍
./dist/assets/js/googlesitekit-splash-********************.js 89 kB +10.7 kB (+13.66%) ⚠️
./dist/assets/js/googlesitekit-user-input-********************.js 62.7 kB +9.52 kB (+17.9%) ⚠️
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB +28 B (+0.01%)
./dist/assets/js/googlesitekit-widgets-********************.js 81.7 kB -116 B (-0.14%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.8 kB +58 B (+0.09%)
./dist/assets/js/runtime-********************.js 1.3 kB +1 B (+0.08%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 57 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.35 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 376 B

compressed-size-action

hussain-t
hussain-t approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @ankitrox. LGTM 👍

I've made a couple of improvements to avoid another iteration. Additionally, I've updated the QAB to verify the banner only on HTTPS-enabled sites.

The VRT build has been failing despite several attempts. It is unrelated to this PR. I ran the VRT locally and confirmed there were no failures.

Screenshot 2024-08-08 at 3 33 30 PM

@hussain-t hussain-t merged commit b143faa into develop Aug 8, 2024
19 of 21 checks passed
@hussain-t hussain-t deleted the fix/8846-move-files branch August 8, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussain-t hussain-t hussain-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankitrox @hussain-t